]> git.nega.tv - josh/narcissus/commitdiff
vulkan-sys: Improve default for ImageSubresourceRange
authorJoshua Simmons <josh@nega.tv>
Mon, 18 Nov 2024 18:00:39 +0000 (19:00 +0100)
committerJoshua Simmons <josh@nega.tv>
Mon, 18 Nov 2024 18:00:39 +0000 (19:00 +0100)
Seems silly to default to something which is always invalid when there's
an easy common use-case which can be handled instead.

external/vulkan-sys/src/structs.rs

index d901985b77a8c538b1d00a90a87367a8ff01db19..c22205d89dca6f63735474b437d594142ad31d73 100644 (file)
@@ -1163,6 +1163,7 @@ impl Default for ImageMemoryBarrier2 {
     fn default() -> Self {
         let mut x = unsafe { MaybeUninit::<Self>::zeroed().assume_init() };
         x._type = StructureType::ImageMemoryBarrier2;
+        x.subresource_range = ImageSubresourceRange::default();
         x
     }
 }
@@ -1937,11 +1938,11 @@ pub struct ImageSubresourceRange {
 impl Default for ImageSubresourceRange {
     fn default() -> Self {
         Self {
-            aspect_mask: Default::default(),
-            base_mip_level: Default::default(),
-            level_count: Default::default(),
-            base_array_layer: Default::default(),
-            layer_count: Default::default(),
+            aspect_mask: ImageAspectFlags::COLOR,
+            base_mip_level: 0,
+            level_count: REMAINING_MIP_LEVELS,
+            base_array_layer: 0,
+            layer_count: REMAINING_ARRAY_LAYERS,
         }
     }
 }