narcissus-gpu: Fix dst_stage_mask for swapchain transition

Open question about whether the spec is right, or the validation layers
are right. But lets go with the validation layers.

diff --git a/engine/narcissus-gpu/src/backend/vulkan/mod.rs b/engine/narcissus-gpu/src/backend/vulkan/mod.rs
index 2d60c00d2ef296329d29f0e025bd741b9cac55a1..366b5ba64743d09c62fbaf5c9032645369458661 100644 (file)
--- a/engine/narcissus-gpu/src/backend/vulkan/mod.rs
+++ b/engine/narcissus-gpu/src/backend/vulkan/mod.rs
@@ -2731,11 +2731,14 @@ impl Device for VulkanDevice {
             stage_mask,
         } in cmd_encoder.swapchains_touched.values()
         {
-            // transition swapchain image from attachment optimal to present src
+            // transition swapchain image to present src
             let image_memory_barriers = &[vk::ImageMemoryBarrier2 {
                 src_stage_mask: stage_mask,
                 src_access_mask: access_mask,
-                dst_stage_mask: vk::PipelineStageFlags2::BOTTOM_OF_PIPE,
+                // According to the vulkan documentation, this should be `vk::PipelineStageFlags2::NONE`, however it
+                // seems that is not true any longer.
+                // see: <https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/6177#issuecomment-1693009636>
+                dst_stage_mask: stage_mask,
                 dst_access_mask: vk::AccessFlags2::NONE,
                 src_queue_family_index: self.universal_queue_family_index,
                 dst_queue_family_index: self.universal_queue_family_index,