From: Joshua Simmons Date: Sat, 29 Oct 2022 14:12:39 +0000 (+0200) Subject: Rename `request_command_buffer` to `create_...` X-Git-Url: https://git.nega.tv//gitweb.cgi?a=commitdiff_plain;h=78042e21517a2bae4e2fd7758962480bb6a656ef;p=josh%2Fnarcissus Rename `request_command_buffer` to `create_...` The distinction between requesting and creating seems a bit tenuious and probably just confusing. Might re-visit this later once the API is more complete. --- diff --git a/narcissus-gpu/src/lib.rs b/narcissus-gpu/src/lib.rs index 3663537..e78813e 100644 --- a/narcissus-gpu/src/lib.rs +++ b/narcissus-gpu/src/lib.rs @@ -241,7 +241,7 @@ pub trait Device { ) -> (u32, u32, Texture); fn destroy_window(&self, window: Window); - fn request_command_buffer<'frame>( + fn create_command_buffer<'frame>( &'frame self, frame_token: &'frame FrameToken, thread_token: &'frame mut ThreadToken, diff --git a/narcissus-gpu/src/vulkan.rs b/narcissus-gpu/src/vulkan.rs index 5167788..13e4455 100644 --- a/narcissus-gpu/src/vulkan.rs +++ b/narcissus-gpu/src/vulkan.rs @@ -1688,7 +1688,7 @@ impl<'driver> Device for VulkanDevice<'driver> { } } - fn request_command_buffer<'frame>( + fn create_command_buffer<'frame>( &'frame self, frame_token: &'frame FrameToken, thread_token: &'frame mut ThreadToken, diff --git a/narcissus/src/main.rs b/narcissus/src/main.rs index d58b36d..b6e601f 100644 --- a/narcissus/src/main.rs +++ b/narcissus/src/main.rs @@ -171,7 +171,7 @@ fn render_window( ) { let (width, height, swapchain_image) = device.acquire_swapchain(frame_token, window, TextureFormat::BGRA8_SRGB); - let mut command_buffer_token = device.request_command_buffer(frame_token, thread_token); + let mut command_buffer_token = device.create_command_buffer(frame_token, thread_token); device.cmd_begin_rendering( &mut command_buffer_token, &RenderingDesc {