From 0cd7a95c1313d26170d485a5c13c419eed37c462 Mon Sep 17 00:00:00 2001
From: Josh Simmons <josh@nega.tv>
Date: Tue, 18 Jun 2024 22:50:00 +0200
Subject: [PATCH] narcissus: Fix clippy lints

---
 engine/narcissus-core/src/arena.rs               | 2 +-
 engine/narcissus-core/src/virtual_vec/deque.rs   | 2 +-
 engine/narcissus-core/src/virtual_vec/raw_vec.rs | 2 +-
 engine/narcissus-maths/src/quat.rs               | 8 ++++----
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/engine/narcissus-core/src/arena.rs b/engine/narcissus-core/src/arena.rs
index a13ab01..3520edc 100644
--- a/engine/narcissus-core/src/arena.rs
+++ b/engine/narcissus-core/src/arena.rs
@@ -173,7 +173,7 @@ unsafe fn prepend_new_page(page: PagePointer, layout: Layout) -> Option<PagePoin
     // Clamp between `PAGE_MIN_SIZE` and `PAGE_MAX_SIZE` to handle the case where
     // the existing page is the empty page, and to avoid overly large allocated
     // blocks.
-    let new_page_size = new_page_size.max(PAGE_MIN_SIZE).min(PAGE_MAX_SIZE);
+    let new_page_size = new_page_size.clamp(PAGE_MIN_SIZE, PAGE_MAX_SIZE);
     // Ensure that after all that, the given page is large enough to hold the thing
     // we're trying to allocate.
     let new_page_size = new_page_size.max(layout.size() + (layout.align() - 1) + PAGE_FOOTER_SIZE);
diff --git a/engine/narcissus-core/src/virtual_vec/deque.rs b/engine/narcissus-core/src/virtual_vec/deque.rs
index 9f94738..44cae4a 100644
--- a/engine/narcissus-core/src/virtual_vec/deque.rs
+++ b/engine/narcissus-core/src/virtual_vec/deque.rs
@@ -22,7 +22,7 @@ impl<T> VirtualDeque<T> {
 
     pub fn with_capacity(capacity: usize, max_capacity: usize) -> Self {
         assert!(max_capacity.is_power_of_two());
-        assert!(max_capacity < std::isize::MAX as usize);
+        assert!(max_capacity < isize::MAX as usize);
         let cap = std::cmp::max(capacity + 1, MINIMUM_CAPACITY + 1).next_power_of_two();
         Self {
             buf: VirtualRawVec::with_capacity(cap, max_capacity),
diff --git a/engine/narcissus-core/src/virtual_vec/raw_vec.rs b/engine/narcissus-core/src/virtual_vec/raw_vec.rs
index 3280b6c..c119cb2 100644
--- a/engine/narcissus-core/src/virtual_vec/raw_vec.rs
+++ b/engine/narcissus-core/src/virtual_vec/raw_vec.rs
@@ -30,7 +30,7 @@ impl<T> VirtualRawVec<T> {
         let max_capacity_bytes = size.checked_mul(max_capacity).unwrap();
 
         // Check overflow of rounding operation.
-        assert!(max_capacity_bytes <= (std::usize::MAX - (align - 1)));
+        assert!(max_capacity_bytes <= (usize::MAX - (align - 1)));
 
         let ptr = virtual_reserve(max_capacity_bytes).expect("mapping failed");
         let ptr = unsafe { NonNull::new_unchecked(ptr as *mut T) };
diff --git a/engine/narcissus-maths/src/quat.rs b/engine/narcissus-maths/src/quat.rs
index 870d909..aa6e082 100644
--- a/engine/narcissus-maths/src/quat.rs
+++ b/engine/narcissus-maths/src/quat.rs
@@ -25,10 +25,10 @@ impl Quat {
     };
 
     pub const NAN: Self = Self {
-        a: std::f32::NAN,
-        b: std::f32::NAN,
-        c: std::f32::NAN,
-        d: std::f32::NAN,
+        a: f32::NAN,
+        b: f32::NAN,
+        c: f32::NAN,
+        d: f32::NAN,
     };
 
     /// Create a new quaternion from its components.
-- 
2.49.0